Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

refactor: avoid routing tables returning errors due to incorrect metadata #225

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

chunshao90
Copy link
Contributor

@chunshao90 chunshao90 commented Sep 4, 2023

…eturn error

Which issue does this PR close?

Closes #

Rationale for this change

What changes are included in this PR?

Avoid routing tables returning errors due to incorrect metadata.

Are there any user-facing changes?

Avoid routing tables returning errors due to incorrect metadata.

How does this change test

Manual test and CI.

@chunshao90 chunshao90 changed the title refactor: ignoring routing table failure due to incorrect metadata refactor: avoid routing tables returning errors due to incorrect metadata Sep 4, 2023
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #225 (52aaac9) into main (7f1354e) will increase coverage by 21.39%.
Report is 29 commits behind head on main.
The diff coverage is 64.24%.

@@             Coverage Diff             @@
##             main     #225       +/-   ##
===========================================
+ Coverage   39.66%   61.06%   +21.39%     
===========================================
  Files          34       43        +9     
  Lines        4213     5339     +1126     
===========================================
+ Hits         1671     3260     +1589     
+ Misses       2317     1677      -640     
- Partials      225      402      +177     
Files Changed Coverage Δ
pkg/coderr/code.go 0.00% <ø> (ø)
server/cluster/metadata/types.go 0.00% <0.00%> (ø)
server/coordinator/procedure/util.go 0.00% <ø> (ø)
server/storage/meta.go 0.00% <ø> (ø)
server/storage/storage_impl.go 57.21% <0.00%> (-5.10%) ⬇️
server/member/watch_leader.go 40.62% <20.00%> (-2.71%) ⬇️
server/cluster/manager.go 38.96% <23.18%> (ø)
server/coordinator/factory.go 76.68% <27.27%> (+72.22%) ⬆️
.../operation/transferleader/batch_transfer_leader.go 33.80% <33.80%> (ø)
server/member/member.go 47.70% <47.82%> (-1.02%) ⬇️
... and 21 more

... and 1 file with indirect coverage changes

Copy link
Contributor

@ZuLiangWang ZuLiangWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZuLiangWang ZuLiangWang merged commit b14d5e7 into apache:main Sep 4, 2023
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants